Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rusk-wallet binary building #2170

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Fix rusk-wallet binary building #2170

merged 4 commits into from
Aug 21, 2024

Conversation

Daksh14
Copy link
Contributor

@Daksh14 Daksh14 commented Aug 20, 2024

  • Add correct branch name
  • Add --mainfest-path to cargo pkgid command

Closes #2169

@Daksh14
Fix branch name
f1470ec 
Add `--mainfest-path` to `cargo pkgid` command
@Daksh14 Daksh14 requested a review from HDauven August 20, 2024 19:24
HDauven
HDauven previously approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@HDauven HDauven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Daksh14 Daksh14 requested a review from HDauven August 21, 2024 00:06
@Daksh14 Daksh14 force-pushed the fix-rusk-wallet-build branch from 24315cd to 66e7ed4 Compare August 21, 2024 00:07
@Daksh14 Daksh14 merged commit 2753374 into master Aug 21, 2024
15 checks passed
@Daksh14 Daksh14 deleted the fix-rusk-wallet-build branch August 21, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HDauven HDauven HDauven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the rusk-wallet build CI
2 participants
@Daksh14 @HDauven